Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(@astrojs/lit): adding tests #3375

Merged
merged 2 commits into from
May 16, 2022
Merged

test(@astrojs/lit): adding tests #3375

merged 2 commits into from
May 16, 2022

Conversation

jdvivar
Copy link
Contributor

@jdvivar jdvivar commented May 16, 2022 •
edited
Loading

Changes

  • Adding missing unit tests to public functions of @astrojs/lit
  • Removing an edge case if render is called with no attrs/props

Testing

Added tests, also for the small fix discovered precisely when writing these tests 🤓

Docs

There are no new features added

Notes

I've used mocha, chai and cheerio because I saw that was being used throughout the project.

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 6ed1d28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/lit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) labels May 16, 2022
matthewp
matthewp approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matthewp matthewp merged commit fe61e46 into withastro:main May 16, 2022
@github-actions github-actions bot mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdvivar @matthewp